Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE] feat: 폰트 추가 #672

Merged
merged 2 commits into from
Sep 21, 2023
Merged

[FE] feat: 폰트 추가 #672

merged 2 commits into from
Sep 21, 2023
+25 −0

Conversation

hae-on
Copy link
Collaborator

@hae-on hae-on commented Sep 19, 2023 •
edited
Loading

Issue

✨ 구현한 기능

폰트를 추가하고 preload 설정을 하였습니다.

📢 논의하고 싶은 내용

디자인 시스템에서 그냥 font 파일을 도려내버렸는데요.
pretendard 관련만 지웠어야했나요?
여기서 또 따로 추가해줄게 있는건 아니죠...?
아리송하네용

https://github.com/orioncactus/pretendard

🎸 기타

  • 특이 사항이 있으면 작성합니다.

⏰ 일정

  • 추정 시간 : 30분
  • 걸린 시간 : 5분

@hae-on hae-on self-assigned this Sep 19, 2023
@github-actions
Copy link

github-actions bot commented Sep 19, 2023 •
edited
Loading

Test Results

8 tests   - 216   8 ✔️  - 216   7s ⏱️ -19s
3 suites  - 109   0 💤 ±    0 
1 files    - 111   0 ❌ ±    0 

Results for commit d5aac09. ± Comparison against base commit 66a2147.

♻️ This comment has been updated with latest results.

Leejin-Yang
Leejin-Yang reviewed Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@Leejin-Yang Leejin-Yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

글로벌 스타일에 폰트 패밀리 추가해주세요~

Leejin-Yang
Leejin-Yang approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@Leejin-Yang Leejin-Yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿입니다~

xodms0309
xodms0309 approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@xodms0309 xodms0309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿입니다

@hae-on hae-on merged commit 7d0cc01 into develop Sep 21, 2023
3 checks passed
@hae-on hae-on deleted the feat/issue-671 branch September 21, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leejin-Yang Leejin-Yang Leejin-Yang approved these changes

@xodms0309 xodms0309 xodms0309 approved these changes

Assignees

@hae-on hae-on

Labels
🔑 FE ✨ Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FE] font 추가
3 participants
@hae-on @xodms0309 @Leejin-Yang